SONARJAVA-4960 False positive for S1854 #5378
Conversation
rombirli
force-pushed
the
rombirli/S1854-false-positive
branch
from
19d09dc to
947f918
Compare
|
This PR is stale because it has been open 7 days with no activity. If there is no activity in the next 7 days it will be closed automatically |
java-checks/src/test/java/org/sonar/java/checks/DeadStoreCheckTest.java
Outdated
Show resolved
Hide resolved
...-checks-test-sources/default/src/main/files/non-compiling/checks/UnusedVariablesFPCheck.java
Show resolved
Hide resolved
...-checks-test-sources/default/src/main/files/non-compiling/checks/UnusedVariablesFPCheck.java
Outdated
Show resolved
Hide resolved
|
|
This PR is stale because it has been open 7 days with no activity. If there is no activity in the next 7 days it will be closed automatically |
|
|
||
| @Override | ||
| public boolean isMethodSymbol() { | ||
| return true; |
There was a problem hiding this comment.
I flipped it to false and re-run unit tests (SymbolsTest) and everything passed. Could we unit test it?
There was a problem hiding this comment.
Adding a test, however flipping it back to false makes DeadStoreCheckTest.test_incomplete_semantic fail
java-checks/src/test/java/org/sonar/java/checks/DeadStoreCheckTest.java
Outdated
Show resolved
Hide resolved
rombirli
force-pushed
the
rombirli/S1854-false-positive
branch
from
eb0e8ef to
b23c2de
Compare
|
Addressed both issues in d78ed6b |
|
2 participants
Uh oh!
There was an error while loading. Please reload this page.